Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set automation name for root AC element in UWP/WinUI3 renderer #8875

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

sosharm
Copy link
Collaborator

@sosharm sosharm commented Apr 15, 2024

Related Issue

#8874

Description

The speak property is not being hooked up for UWP and WinUI3 renderers.
Setting the automation name for the card root using the speak property in the template.

How Verified

Verified the fix by using the CalendarReminder sample in the Visualizer which has a speak property.
Narrator reads the speak property in the UWP and WinUI3 Visualizers.

@sosharm
Copy link
Collaborator Author

sosharm commented Apr 16, 2024

@jwoo-msft @paulcam206

@paulcam206
Copy link
Member

Looks good -- I'll run CI :)

@paulcam206
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@microsoft microsoft deleted a comment from azure-pipelines bot Apr 17, 2024
@paulcam206
Copy link
Member

/azp run AdaptiveCards-SharedModel-CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulcam206
Copy link
Member

/azp run uwp-ci.yml

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulcam206 paulcam206 merged commit f273118 into microsoft:main Apr 18, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants